engine/schema: fix IDEMPOTENT_ADD_FOREIGN_KEY procedure does not work on mysql8#7252
Merged
DaanHoogland merged 1 commit intoapache:mainfrom Feb 17, 2023
Conversation
… on mysql8
On centos7 with mysql 5.5, it looks good
```
MariaDB [cloud]> CALL `cloud`.`IDEMPOTENT_ADD_FOREIGN_KEY`('cloud.volumes', 'passphrase', 'id');
Query OK, 0 rows affected, 2 warnings (0.03 sec)
MariaDB [cloud]> CALL `cloud`.`IDEMPOTENT_ADD_FOREIGN_KEY`('cloud.volumes', 'passphrase', 'id');
Query OK, 0 rows affected, 2 warnings (0.02 sec)
```
However, it throws an error on ubuntu 22 or rocky8, with mariadb 8
```
mysql> CALL `cloud`.`IDEMPOTENT_ADD_FOREIGN_KEY`('cloud.volumes', 'passphrase', 'id');
ERROR 1826 (HY000): Duplicate foreign key constraint name 'fk_passphrase_id'
mysql> CALL `cloud`.`IDEMPOTENT_ADD_FOREIGN_KEY`('cloud.volumes', 'passphrase', 'id');
ERROR 1826 (HY000): Duplicate foreign key constraint name 'fk_passphrase_id'
```
Member
Author
|
@blueorangutan package |
|
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5598 |
|
Kudos, SonarCloud Quality Gate passed!
|
borisstoyanov
approved these changes
Feb 17, 2023
Contributor
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, got past that point in my latest upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On centos7 with mysql 5.5, it looks good
However, it throws an error on ubuntu 22 or rocky8, with mariadb 8
With this PR, everything looks good
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?